linux-kernel - Re: [PATCH] pci: add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84660edf-3a19-0400-4fa7-8f26ae5e4218@synopsys.com>
Date:   Fri, 21 Jul 2017 12:38:32 +0100
From:   Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <bhelgaas@...gle.com>, <gwshan@...ux.vnet.ibm.com>
Subject: Re: [PATCH] pci: add missing __iomem cast

Hi Christoph,

Looking deep into to this, i think there is no need to use phy_to_virts since pdev->rom is already a physical address.
That's what pci_platform_rom should return, right?!

I'll probably send a new patch removing the usage of phys_to_virt.

Regards,
C.Palminha

On 20-07-2017 09:07, Christoph Hellwig wrote:
> On Wed, Jul 19, 2017 at 01:05:35PM +0100, Carlos Palminha wrote:
>> Add missing __iomem annotation to fix sparse warning:
>> - incorrect type in return expression (different address spaces)
> 
> How is this going to shut up sparse without a __force?
> 
> And once you add the __force please also add a comment explaining
> why it's safe.
>