linux-kernel - Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D6633BE9-51E0-434B-B536-D94DE9342C10@holtmann.org>
Date:   Fri, 21 Jul 2017 17:01:39 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        shawn.lin@...k-chips.com, adrian.hunter@...el.com,
        baolin.wang@...aro.org, hdegoede@...hat.com,
        maxime.ripard@...e-electrons.com,
        thomas.petazzoni@...e-electrons.com, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, devel@...verdev.osuosl.org,
        icenowy@...c.xyz, wens@...e.org
Subject: Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

Hi Quentin,

> The Espressif ESP8089 WiFi chips can be often found in cheap tablets.
> There is one in A23 Polaroid tablets for example.
> 
> The chip is often embedded as an eMMC SDIO device.
> 
> The code was taken from an out-of-tree repository and has seen a first
> pass in the cleanup process.
> 
> At the moment, there is no publicly available datasheet for this chip.
> 
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Icenowy Zheng <icenowy@...c.xyz>
> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
> ---
> drivers/staging/Kconfig                     |    2 +
> drivers/staging/Makefile                    |    1 +
> drivers/staging/esp8089/Kconfig             |   13 +
> drivers/staging/esp8089/Makefile            |    7 +
> drivers/staging/esp8089/esp_ctrl.c          |  527 ++++++++
> drivers/staging/esp8089/esp_ctrl.h          |   48 +
> drivers/staging/esp8089/esp_debug.c         |  247 ++++
> drivers/staging/esp8089/esp_debug.h         |   69 ++
> drivers/staging/esp8089/esp_file.c          |  221 ++++
> drivers/staging/esp8089/esp_file.h          |   30 +
> drivers/staging/esp8089/esp_init_data.h     |   17 +
> drivers/staging/esp8089/esp_io.c            |  294 +++++
> drivers/staging/esp8089/esp_mac80211.c      | 1496 +++++++++++++++++++++++
> drivers/staging/esp8089/esp_mac80211.h      |   33 +
> drivers/staging/esp8089/esp_main.c          |  199 ++++
> drivers/staging/esp8089/esp_pub.h           |  188 +++
> drivers/staging/esp8089/esp_sif.h           |  131 ++
> drivers/staging/esp8089/esp_sip.c           | 1718 +++++++++++++++++++++++++++
> drivers/staging/esp8089/esp_sip.h           |  150 +++
> drivers/staging/esp8089/esp_utils.c         |  133 +++
> drivers/staging/esp8089/esp_utils.h         |   27 +
> drivers/staging/esp8089/esp_wl.h            |   35 +
> drivers/staging/esp8089/esp_wmac.h          |   87 ++
> drivers/staging/esp8089/sdio_sif_esp.c      |  552 +++++++++
> drivers/staging/esp8089/sip2_common.h       |  388 ++++++
> drivers/staging/esp8089/slc_host_register.h |  263 ++++
> 26 files changed, 6876 insertions(+)
> create mode 100644 drivers/staging/esp8089/Kconfig
> create mode 100644 drivers/staging/esp8089/Makefile
> create mode 100644 drivers/staging/esp8089/esp_ctrl.c
> create mode 100644 drivers/staging/esp8089/esp_ctrl.h
> create mode 100644 drivers/staging/esp8089/esp_debug.c
> create mode 100644 drivers/staging/esp8089/esp_debug.h
> create mode 100644 drivers/staging/esp8089/esp_file.c
> create mode 100644 drivers/staging/esp8089/esp_file.h
> create mode 100644 drivers/staging/esp8089/esp_init_data.h
> create mode 100644 drivers/staging/esp8089/esp_io.c
> create mode 100644 drivers/staging/esp8089/esp_mac80211.c
> create mode 100644 drivers/staging/esp8089/esp_mac80211.h
> create mode 100644 drivers/staging/esp8089/esp_main.c
> create mode 100644 drivers/staging/esp8089/esp_pub.h
> create mode 100644 drivers/staging/esp8089/esp_sif.h
> create mode 100644 drivers/staging/esp8089/esp_sip.c
> create mode 100644 drivers/staging/esp8089/esp_sip.h
> create mode 100644 drivers/staging/esp8089/esp_utils.c
> create mode 100644 drivers/staging/esp8089/esp_utils.h
> create mode 100644 drivers/staging/esp8089/esp_wl.h
> create mode 100644 drivers/staging/esp8089/esp_wmac.h
> create mode 100644 drivers/staging/esp8089/sdio_sif_esp.c
> create mode 100644 drivers/staging/esp8089/sip2_common.h
> create mode 100644 drivers/staging/esp8089/slc_host_register.h

why are you putting this into staging? Is it that bad?

Regards

Marcel