linux-kernel - [PATCH v2] of: provide of_n_{addr,size}_cells wrappers for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170721211000.3382004-1-arnd@arndb.de>
Date:   Fri, 21 Jul 2017 23:09:50 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
        Magnus Damm <damm@...nsource.se>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Ben Dooks <ben.dooks@...ethink.co.uk>,
        linux-pci@...r.kernel.org, linux-sh@...r.kernel.org,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF

The pci-rcar driver is enabled for compile tests, and this has
shown that the driver cannot build without CONFIG_OF:

drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init':
drivers/pci/host/pcie-rcar.c:1039:2: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
  parser->pna = of_n_addr_cells(node);
  ^
As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually
supposed to build fine, which we can achieve if we make the
declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF
and provide an empty inline function otherwise, as we do for
a lot of other of interfaces.

This lets us build the rcar_pci driver again without CONFIG_OF
for build testing. All platforms using this driver select OF,
so this doesn't change anything for the users.

Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Magnus Damm <damm@...nsource.se>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Ben Dooks <ben.dooks@...ethink.co.uk>
Cc: linux-pci@...r.kernel.org
Cc: linux-sh@...r.kernel.org
Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>
Reviewed-by: Frank Rowand <frank.rowand@...y.com>
Fixes: c25da4778803 ("PCI: rcar: Add Renesas R-Car PCIe driver")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
I originally sent the patch in 2014 when things initially broke
and then forgot about while it was applied in my randconfig patch
stack. I sent it again in 2016 without reply.

It's still broken and I think this is the correct fix.
v2: modify changelog as Geert suggested.

 include/linux/of.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index 4a8a70916237..1efdbe53136c 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -735,6 +735,9 @@ static inline struct device_node *of_get_cpu_node(int cpu,
 	return NULL;
 }
 
+static inline int of_n_addr_cells(struct device_node *np) { return 0; }
+static inline int of_n_size_cells(struct device_node *np) { return 0; }
+
 static inline int of_property_read_u64(const struct device_node *np,
 				       const char *propname, u64 *out_value)
 {
-- 
2.9.0