lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Jul 2017 00:48:06 +0300 From: Alexey Khoroshilov <khoroshilov@...ras.ru> To: Darren Hart <dvhart@...radead.org>, Andy Shevchenko <andy@...radead.org> Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org Subject: [PATCH] platform/x86: wmi: Fix error handling in acpi_wmi_init() The order of resource deallocations is messed up in acpi_wmi_init(). It should be vice versa. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> --- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 1a764e311e11..e32ba575e8d9 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1252,12 +1252,12 @@ static int __init acpi_wmi_init(void) return 0; -err_unreg_class: - class_unregister(&wmi_bus_class); - err_unreg_bus: bus_unregister(&wmi_bus_type); +err_unreg_class: + class_unregister(&wmi_bus_class); + return error; } -- 2.7.4
Powered by blists - more mailing lists