linux-kernel - RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2017 03:29:39 +0000
From:   "Chakravarty, Souvik K" <souvik.k.chakravarty@...el.com>
To:     "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@...el.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
CC:     "dvhart@...radead.org" <dvhart@...radead.org>,
        "andy@...radead.org" <andy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Murthy, Shanth" <shanth.murthy@...el.com>,
        "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@...el.com>
Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

Just missed the email from Darren.

Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@...el.com>

> -----Original Message-----
> From: Chakravarty, Souvik K
> Sent: Friday, July 21, 2017 8:45 AM
> To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@...el.com>; platform-driver-
> x86@...r.kernel.org
> Cc: dvhart@...radead.org; andy@...radead.org; linux-
> kernel@...r.kernel.org; Murthy, Shanth <shanth.murthy@...el.com>;
> Bhardwaj, Rajneesh <rajneesh.bhardwaj@...el.com>
> Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Both set of two looks good. +1.
> 
> > -----Original Message-----
> > From: platform-driver-x86-owner@...r.kernel.org
> > [mailto:platform-driver- x86-owner@...r.kernel.org] On Behalf Of
> > Rajneesh Bhardwaj
> > Sent: Thursday, July 20, 2017 7:51 PM
> > To: platform-driver-x86@...r.kernel.org
> > Cc: dvhart@...radead.org; andy@...radead.org; linux-
> > kernel@...r.kernel.org; Murthy, Shanth <shanth.murthy@...el.com>;
> > Chakravarty, Souvik K <souvik.k.chakravarty@...el.com>; Bhardwaj,
> > Rajneesh <rajneesh.bhardwaj@...el.com>
> > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> >
> > Telemetry driver includes intel_telemetry.h which defines
> > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> >
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
> > ---
> >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > index 6393b3b1d5a6..e0424d5a795a 100644
> > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > @@ -46,7 +46,6 @@
> >  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> >
> >  #define TELEM_MAX_EVENTS_SRAM		28
> > -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
> >  #define TELEM_SSRAM_STARTTIME_OFFSET	8
> >  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> >
> > --
> > 2.7.4