linux-kernel - Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170721234327.GA24530@x1>
Date:   Sat, 22 Jul 2017 07:43:27 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        keescook@...omium.org, matt@...eblueprint.co.uk,
        tglx@...utronix.de, hpa@...or.com, izumi.taku@...fujitsu.com,
        fanc.fnst@...fujitsu.com, thgarnie@...gle.com,
        n-horiguchi@...jp.nec.com
Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be
 randomized in mirror regions

On 07/21/17 at 07:37pm, Ingo Molnar wrote:
> 
> * Baoquan He <bhe@...hat.com> wrote:
> 
> > > > +static inline bool process_efi_entries(unsigned long minimum,
> > > > +				       unsigned long image_size)
> > > 
> > > ugly linebreak again ...
> > 
> > The whole line is more than 80. I break the line and use tab and space
> > to make it align with above 'unsigned long minimum'. Don't know why it
> > becomes messy in patch. Will check and try again.
> 
> Then make the linebreak less ugly, or ignore the checkpatch warning!
> 
> This commonly used pattern:
> 
>   static inline bool
>   process_efi_entries(unsigned long minimum, unsigned long image_size)
> 
> looks a lot better than the function parameter list broken in the middle.

Got it, will use this one. Thanks a lot!