linux-kernel - Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <638a94de-5eb4-eba4-7c28-4b4eb4bf8dbf@embeddedor.com>
Date:   Sat, 22 Jul 2017 11:22:13 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Borislav Petkov <bp@...en8.de>, Julia Lawall <julia.lawall@...6.fr>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        cocci@...teme.lip6.fr
Subject: Re: [PATCH] EDAC: remove unnecessary static in
 edac_fake_inject_write()

Hi all,

On 07/22/2017 01:36 AM, Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote:
>> Someone pointed out that the rule is probably not OK when the address of
>> the static variable is taken, because then it is likely being used as
>> permanent storage.
>
> Makes sense to me.
>
>> An improved rule is:
>
> Do you think it is worth having it in scripts/coccinelle/ ?
>
> I don't think Gustavo would mind putting it there :)
>

Absolutely, I'd be glad to help out. :)

-- 
Gustavo A. R. Silva