linux-kernel - Re: [PATCH] staging: vboxvideo: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0cc6483-4fcb-b58b-5f6a-7a7e995b5271@redhat.com>
Date:   Sat, 22 Jul 2017 20:17:45 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Paolo Cretaro <paolocretaro@...il.com>, gregkh@...uxfoundation.org
Cc:     michael.thayer@...cle.com, daniel@...ll.ch,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vboxvideo: remove unused variables

Hi,

On 22-07-17 12:55, Paolo Cretaro wrote:
> Fix compiler warnings:
> vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used
> vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used
> 
> Signed-off-by: Paolo Cretaro <paolocretaro@...il.com>

Patch looks good to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/staging/vboxvideo/vbox_mode.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index f2b85f3256fa..a7eea70a3804 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -54,14 +54,12 @@ static void vbox_do_modeset(struct drm_crtc *crtc,
>   	struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc);
>   	struct vbox_private *vbox;
>   	int width, height, bpp, pitch;
> -	unsigned int crtc_id;
>   	u16 flags;
>   	s32 x_offset, y_offset;
>   
>   	vbox = crtc->dev->dev_private;
>   	width = mode->hdisplay ? mode->hdisplay : 640;
>   	height = mode->vdisplay ? mode->vdisplay : 480;
> -	crtc_id = vbox_crtc->crtc_id;
>   	bpp = crtc->enabled ? CRTC_FB(crtc)->format->cpp[0] * 8 : 32;
>   	pitch = crtc->enabled ? CRTC_FB(crtc)->pitches[0] : width * bpp / 8;
>   	x_offset = vbox->single_framebuffer ? crtc->x : vbox_crtc->x_hint;
> @@ -578,9 +576,6 @@ static int vbox_mode_valid(struct drm_connector *connector,
>   
>   static void vbox_connector_destroy(struct drm_connector *connector)
>   {
> -	struct vbox_connector *vbox_connector;
> -
> -	vbox_connector = to_vbox_connector(connector);
>   	drm_connector_unregister(connector);
>   	drm_connector_cleanup(connector);
>   	kfree(connector);
>