linux-kernel - Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb12f9cd-46f6-47ae-0306-6d7a6efaa56d@gmail.com>
Date:   Sat, 22 Jul 2017 11:52:38 -0700
From:   Steve Longerbeam <slongerbeam@...il.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Hans Verkuil <hans.verkuil@...co.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

Acked-by: Steve Longerbeam <steve_longerbeam@...tor.com>

On 07/21/2017 09:21 AM, Arnd Bergmann wrote:
> Without this, I get a build error:
> 
> drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt':
> drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]
> 
> Fixes: e130291212df ("[media] media: Add i.MX media core driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/staging/media/imx/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50bcea39..719508fcb0e9 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
>   config VIDEO_IMX_MEDIA
>   	tristate "i.MX5/6 V4L2 media core driver"
>   	depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> +	depends on VIDEO_V4L2_SUBDEV_API
>   	select V4L2_FWNODE
>   	---help---
>   	  Say yes here to enable support for video4linux media controller
>