linux-kernel - Re: [PATCH] staging: vboxvideo: make a couple of symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3541f5b7-b355-c15b-153f-50c609ba3298@oracle.com>
Date:   Sat, 22 Jul 2017 09:22:53 +0200
From:   Michael Thayer <michael.thayer@...cle.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Daniel Vetter <daniel@...ll.ch>, devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vboxvideo: make a couple of symbols static

22.07.2017 00:17, Hans de Goede wrote:
> Hi,
> 
> On 19-07-17 11:36, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Module parameter vbox_modeset and structure vbox_bo_driver do not need to
>> be in global scope and hence can be made static.
>>
>> Cleans up a couple of sparse warnings:
>> symbol 'vbox_modeset' was not declared. Should it be static?
>> symbol 'vbox_bo_driver' was not declared. Should it be static?
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Looks good to me:
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>

Looks good to me too.  Sorry for the slow response.  Still had no time
to actually apply it, but as said, it looks completely sensible.

Regards
Michael

Acked-by: Michael Thayer <michael.thayer@...cle.com>

>> ---
>>   drivers/staging/vboxvideo/vbox_drv.c | 2 +-
>>   drivers/staging/vboxvideo/vbox_ttm.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/vboxvideo/vbox_drv.c
>> b/drivers/staging/vboxvideo/vbox_drv.c
>> index 6d0600c37c0c..e18642e5027e 100644
>> --- a/drivers/staging/vboxvideo/vbox_drv.c
>> +++ b/drivers/staging/vboxvideo/vbox_drv.c
>> @@ -36,7 +36,7 @@
>>     #include "vbox_drv.h"
>>   -int vbox_modeset = -1;
>> +static int vbox_modeset = -1;
>>     MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>>   module_param_named(modeset, vbox_modeset, int, 0400);
>> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c
>> b/drivers/staging/vboxvideo/vbox_ttm.c
>> index 34a905d40735..4eb410a2a1a8 100644
>> --- a/drivers/staging/vboxvideo/vbox_ttm.c
>> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
>> @@ -230,7 +230,7 @@ static void vbox_ttm_tt_unpopulate(struct ttm_tt
>> *ttm)
>>       ttm_pool_unpopulate(ttm);
>>   }
>>   -struct ttm_bo_driver vbox_bo_driver = {
>> +static struct ttm_bo_driver vbox_bo_driver = {
>>       .ttm_tt_create = vbox_ttm_tt_create,
>>       .ttm_tt_populate = vbox_ttm_tt_populate,
>>       .ttm_tt_unpopulate = vbox_ttm_tt_unpopulate,
>>

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher