linux-kernel - Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Jul 2017 11:56:26 +0000
From:   Gabriel FERNANDEZ <gabriel.fernandez@...com>
To:     Stephen Boyd <sboyd@...eaurora.org>,
        Vladimir Zapolskiy <vz@...ia.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Michael Turquette <mturquette@...libre.com>,
        Nicolas Pitre <nico@...aro.org>, Arnd Bergmann <arnd@...db.de>,
        "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
        "andrea.merello@...il.com" <andrea.merello@...il.com>,
        "radoslaw.pietrzyk@...il.com" <radoslaw.pietrzyk@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        "Sylvain Lemieux" <slemieux.tyco@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        Ludovic BARRE <ludovic.barre@...com>,
        "Olivier BIDEAU" <olivier.bideau@...com>,
        Amelie DELAUNAY <amelie.delaunay@...com>,
        "gabriel.fernandez.st@...il.com" <gabriel.fernandez.st@...il.com>,
        "Arvind Yadav" <arvind.yadav.cs@...il.com>
Subject: Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver



On 07/21/2017 10:37 PM, Stephen Boyd wrote:
> On 07/20, Vladimir Zapolskiy wrote:
>> Hi Gabriel,
>>
>> On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote:
>>> Hi Vladimir,
>>>
>>>
>>> On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote:
>>>> Hello Gabriel,
>>>>
>>>> On 07/19/2017 05:25 PM, gabriel.fernandez@...com wrote:
>>>>> From: Gabriel Fernandez <gabriel.fernandez@...com>
>>>>> +
>>>>> +	rcc: rcc@...24400 {
>>>> 'rcc' as a generic device node name is awkward.
>>>>
>>>> I believe the main function of the device is clock controller (unlikely
>>>> a generic reset controller can be converted into a clock controller),
>>>> the locations of the document and device driver also indicate that
>>>> primarily it is a clock controller, so I suggest to replace device node
>>>> name with 'clock-controller' like below:
>>> I prefer to keep rcc node name, to be coherent with the other ST
>>> platforms (STM32F4/F7)
>> the thing is, a device node name is expected to comply with ePAPR or
>> the devicetree specification, which says
>>
>> 	The name of a node should be somewhat generic, reflecting
>> 	the function of the device and not its precise programming model.
>>
>> If devicetree and CCF maintainers are fine with 'rcc', I won't object,
>> my role is just to emphasize the found issue and recommend to use another
>> and more common name 'clock-controller', it is a simple and fortunately
>> backward compatible change to other ST platforms as well.
> Yes. It should be generic so clock-controller or
> clock-reset-controller is appropriate here.
>
ok i will change order... reset-clock-controller name to match with rcc.

Best Regards
Gabriel