linux-kernel - Re: [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D59B92EF.5A232%nilesh.javali@cavium.com>
Date:   Mon, 24 Jul 2017 06:44:13 +0000
From:   "Javali, Nilesh" <Nilesh.Javali@...ium.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Dept-Eng QLogic Storage Upstream 
        <QLogic-Storage-Upstream@...ium.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "Kashyap, Saurav" <Saurav.Kashyap@...ium.com>,
        "Rangankar, Manish" <Manish.Rangankar@...ium.com>,
        Adheer Chandravanshi <adheer.chandravanshi@...gic.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS


On 21/07/17, 9:41 PM, "Arnd Bergmann" <arnd@...db.de> wrote:

>Without the base library support, we get a link failure
>
>drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
>qedi_main.c:(.text+0x2d8e): undefined reference to
>`iscsi_boot_create_target'
>qedi_main.c:(.text+0x2dee): undefined reference to
>`iscsi_boot_create_initiator'
>qedi_main.c:(.text+0x2e1c): undefined reference to
>`iscsi_boot_create_ethernet'
>
>This selects the Kconfig symbol like the other two users of that
>module do.
>
>Fixes: c57ec8fb7c02 ("scsi: qedi: Add support for Boot from SAN over
>iSCSI offload")
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>---
> drivers/scsi/qedi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
>index 21331453db7b..8deb8723c4dd 100644
>--- a/drivers/scsi/qedi/Kconfig
>+++ b/drivers/scsi/qedi/Kconfig
>@@ -2,6 +2,7 @@ config QEDI
> 	tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
> 	depends on PCI && SCSI && UIO
> 	depends on QED
>+	select ISCSI_BOOT_SYSFS
> 	select SCSI_ISCSI_ATTRS
> 	select QED_LL2
> 	select QED_ISCSI
>-- 
>2.9.0
>

NACK. The fix already posted to address this issue,
http://marc.info/?l=linux-scsi&m=150045528332067&w=2

Thanks,
Nilesh