linux-kernel - Re: [PATCH 2/3] staging: pi433: - style fix, space before tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 10:48:58 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Marcus Wolf <marcus.wolf@...f-entwicklungen.de>
Cc:     gregkh@...uxfoundation.org, Derek Robson <robsonde@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: pi433: - style fix, space before tabs

On Sat, Jul 22, 2017 at 10:48:24AM +0200, Marcus Wolf wrote:
> Reviewed-by: Marcus Wolf <linux@...f-entwicklungen.de>
> 
> >From my point of view, the rearrangement of the block of SET_CHECKED reduces the
> readability a lot. I like same stuff to be aligned (all brakets below each other
> as a column, all spi->dev below each other and so on) But if it  is necessary to
> fullfill the rules, we have to do it the new way.

It's not necessary.  The rule is just complaining about this:

        SET_CHECKED(rf69_set_bandwidth 		 (dev->spi, rx_cfg->bw_mantisse, rx_cfg->bw_exponent));
                                      ^
There is a space after the 'h' character.  The old code has
"[space][tab][tab][space](dev->spi,..."  it should be:
"[tab][tab][space](dev->spi, ..."

Also the rules are there to improve readability.  Sometimes they're
debatable but if they make readability worse, then we can ignore the
rules.

regards,
dan carpenter