linux-kernel - Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 10:53:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Derek Robson <robsonde@...il.com>
Cc:     gregkh@...uxfoundation.org, linux@...f-Entwicklungen.de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

On Sat, Jul 22, 2017 at 03:51:21PM +1200, Derek Robson wrote:
> Fixed checkpatch errors of "please, no spaces at the start of a line"
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
>  drivers/staging/pi433/rf69.c      |   4 +-
>  drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
>  2 files changed, 105 insertions(+), 105 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index d931437f0b6a..f450bbf3fbbc 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant
>  	// check value for mantisse and exponent
>  	if (exponent > 7)   INVALID_PARAM;
>  	if ( (mantisse!=mantisse16) &&
> -	     (mantisse!=mantisse20) &&
> -             (mantisse!=mantisse24) ) INVALID_PARAM;
> +		(mantisse!=mantisse20) &&
> +		(mantisse!=mantisse24) ) INVALID_PARAM;
>  

This is wrong.  It should be aligned like this:

	if (exponent > 7)
		INVALID_PARAM;
	if (mantisse != mantisse16 &&
	    mantisse != mantisse20 &&
	    mantisse != mantisse24)
		INVALID_PARAM;

regards,
dan carpenter