linux-kernel - Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6b182f8-50c0-04ae-570b-5a6369fb50dd@codeaurora.org>
Date:   Mon, 24 Jul 2017 14:12:11 +0530
From:   Manu Gautam <mgautam@...eaurora.org>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        USB <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linaro Kernel Mailman List <linaro-kernel@...ts.linaro.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

Hi Baolin,


On 7/24/2017 11:26 AM, Baolin Wang wrote:

>>>> Other than what I pushed in my patch -
>>>> ("usb: dwc3: Don't reinitialize core during host bus-suspend/resume")
>>>> Just performing pm_request_resume or handling same in dwc3 glue
>>>> driver should be sufficient.
>>> Yes.
>>>
>>>> Also, what is trigger for runtime_resume for your platform?
>>> In our platform glue layer, we have extcon events to notify there are
>>> devices connected, then gule layer will resume dwc3 device.
>>>
>> IMO you can just perform resume of &dwc->xhci->dev instead of resuming dwc3.
>> Since, dwc3 is parent of xhci that will trigger resume of dwc3 as well.
> I am not sure this is good enough but it seems can solve some
> problems, then we do not need resume/suspend host in dwc3 core.

In that case can we proceed with this patch:
[1] https://www.spinics.net/lists/linux-usb/msg158682.html

For your platform you can pick this patch and resume dwc->xhci->dev resume
from your glue driver.
Do you have any other concerns?