linux-kernel - Re: [PATCH 2/4] mm, page_ext: periodically reschedule during page_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 14:45:06 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Yang Shi <yang.shi@...aro.org>,
        Laura Abbott <labbott@...hat.com>,
        Vinayak Menon <vinmenon@...eaurora.org>,
        zhong jiang <zhongjiang@...wei.com>
Subject: Re: [PATCH 2/4] mm, page_ext: periodically reschedule during
 page_ext_init()

On Thu 20-07-17 15:40:27, Vlastimil Babka wrote:
> page_ext_init() can take long on large machines, so add a cond_resched() point
> after each section is processed. This will allow moving the init to a later
> point at boot without triggering lockup reports.
> 
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/page_ext.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 88ccc044b09a..24cf8abefc8d 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -409,6 +409,7 @@ void __init page_ext_init(void)
>  				continue;
>  			if (init_section_page_ext(pfn, nid))
>  				goto oom;
> +			cond_resched();
>  		}
>  	}
>  	hotplug_memory_notifier(page_ext_callback, 0);
> -- 
> 2.13.2

-- 
Michal Hocko
SUSE Labs