linux-kernel - Re: [PATCH 1/2] ARM: dts: imx6qdl-sabrelite: fix USB PHY reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAMH-yvt3cZ3yzfMe6g6o9AoD=xAyH37os_FnkMgR3Au1FhL4g@mail.gmail.com>
Date:   Mon, 24 Jul 2017 14:52:57 +0200
From:   Gary Bisson <gary.bisson@...ndarydevices.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] ARM: dts: imx6qdl-sabrelite: fix USB PHY reset

Hi Fabio,

On Mon, Jul 24, 2017 at 2:49 PM, Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Gary,
>
> On Mon, Jul 24, 2017 at 5:50 AM, Gary Bisson
> <gary.bisson@...ndarydevices.com> wrote:
>
> > +
> > +               reg_usb_h1_vbus: regulator@7 {
> > +                       compatible = "regulator-fixed";
> > +                       reg = <7>;
> > +                       pinctrl-names = "default";
> > +                       pinctrl-0 = <&pinctrl_usbh1>;
> > +                       regulator-name = "usb_h1_vbus";
> > +                       regulator-min-microvolt = <3300000>;
> > +                       regulator-max-microvolt = <3300000>;
> > +                       gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
> > +                       enable-active-high;
> > +                       regulator-always-on;
>
> As this regulator is controlled via GPIO I believe you should remove
> the ' regulator-always-on' property.
>
> Same applies to 2/2/

Good catch, I'll send a v2 right away.

Thanks,
Gary