linux-kernel - Re: [PATCH] perf, tools: Make build fail on JSON parse error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170724141649.GA2645@krava>
Date:   Mon, 24 Jul 2017 16:16:49 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools: Make build fail on JSON parse error

On Fri, Jul 21, 2017 at 05:31:59PM -0700, Sukadev Bhattiprolu wrote:
> Andi Kleen [andi@...stfloor.org] wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > Today, when a JSON file fails parsing the build continues,
> > but there are no json files built in, which is difficult to debug later.
> > Make the build stop on a parse error instead.
> 
> I see the problem and we were being defensive to not break the build
> on architectures that don't yet have the PMU event lists. It will be
> good to check build on an architecture other than x86/powerpc.
> 
> Also, following comments may no longer be applicable?

Isn't the Andi's change only to fail in case there's
a real error in process_one_file? I think you can still
have empty events dir.

jirka