linux-kernel - Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3e54db0-eb8d-9316-e8d1-9cf097aef506@redhat.com>
Date:   Mon, 24 Jul 2017 16:28:03 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Wanpeng Li <kernellwp@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvm <kvm@...r.kernel.org>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested
 vmexit if inject #PF

On 24/07/2017 15:57, Wanpeng Li wrote:
> 
>      if (!((vmcs12->exception_bitmap & (1u << nr)) ||
> -        (nr == PF_VECTOR && vcpu->arch.exception.nested_apf)))
> +        (nr == PF_VECTOR && (vcpu->arch.exception.nested_apf ||
> +            nested_vmx_is_page_fault_vmexit(vmcs12,
> vcpu->arch.exception.error_code)))))
>          return 0;

No, it would be more like

	if (nr == PF_VECTOR
	    ? (vcpu->arch.exception.nested_apf ||
               nested_vmx_is_page_fault_vmexit(vmcs12, vcpu->arch.exception.error_code))
            : (vmcs12->exception_bitmap & (1u << nr)))

but I've sent an RFC patch that also fixes the exit qualification.

Paolo