linux-kernel - Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 13:45:13 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     linux-input <linux-input@...r.kernel.org>,
        Andrew Duggan <aduggan@...aptics.com>, stable@...r.kernel.org,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Sun, 2017-07-23 at 12:54 +0300, Andy Shevchenko wrote:
> On Sun, Jul 23, 2017 at 4:15 AM, Lyude <lyude@...hat.com> wrote:
> 
> > So, call hid_hw_open() in rmi_post_resume() so we make sure that
> > the
> > device is alive before we try talking to it.
> > 
> > This fixes RMI device suspend/resume over HID.
> > -       int ret;
> > +       int ret = 0;
> 
> What's the point?
So that we can use the same out: label at the end of the function that
calls hid_hw_close() to return success. This being said though I just
realized that setting ret will initialize it to 0 anyway, so I guess
this can be dropped
> 
> > 
> >         if (!(data->device_flags & RMI_DEVICE))
> >                 return 0;
> > 
> > -       ret = rmi_reset_attn_mode(hdev);
> > +       /* Make sure the HID device is ready to receive events */
> > +       ret = hid_hw_open(hdev);
> >         if (ret)
> >                 return ret;
> 
>