linux-kernel - Re: [PATCH] power: supply: cpcap-charger: add OMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170724185116.6dnjyelzf4l37fmk@earth>
Date:   Mon, 24 Jul 2017 20:51:16 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: cpcap-charger:  add OMAP_USB2 dependency

Hi,

On Fri, Jul 21, 2017 at 06:14:37PM +0200, Arnd Bergmann wrote:
> When CONFIG_OMAP_USB2 is set to 'm' and the charger driver is built-in,
> we get this link failure:
> 
> drivers/power/supply/cpcap-charger.o: In function `cpcap_charger_probe':
> cpcap-charger.c:(.text+0x48c): undefined reference to `omap_usb2_set_comparator'
> drivers/power/supply/cpcap-charger.o: In function `cpcap_charger_remove':
> cpcap-charger.c:(.text+0x774): undefined reference to `omap_usb2_set_comparator'
> 
> This adds a dependency to prevent that problem, while still allowing
> compile-testing with the OMAP_USB2 driver completely disabled.
> 
> Fixes: 0c9888e3c192 ("power: supply: cpcap-charger: Add minimal CPCAP PMIC battery charger")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Thanks, applied to power-supply's fixes branch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)