linux-kernel - Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1707242127300.4705@cbobk.fhfr.pm>
Date:   Mon, 24 Jul 2017 21:28:22 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Lyude Paul <lyude@...hat.com>
cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-input <linux-input@...r.kernel.org>,
        Andrew Duggan <aduggan@...aptics.com>, stable@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Mon, 24 Jul 2017, Lyude Paul wrote:

> > > So, call hid_hw_open() in rmi_post_resume() so we make sure that
> > > the
> > > device is alive before we try talking to it.
> > > 
> > > This fixes RMI device suspend/resume over HID.
> > > -       int ret;
> > > +       int ret = 0;
> > 
> > What's the point?
> So that we can use the same out: label at the end of the function that
> calls hid_hw_close() to return success. This being said though I just
> realized that setting ret will initialize it to 0 anyway, so I guess
> this can be dropped

Andy's point was that hid_hw_open() is obviously re-initializing the ret 
before its first use as a return value, so there is no need to initialize 
it at a declaration time.

-- 
Jiri Kosina
SUSE Labs