linux-kernel - Re: [PATCH 07/10] percpu: fix misnomer in schunk/dchunk variable names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170724200719.GB91613@dennisz-mbp.dhcp.thefacebook.com>
Date:   Mon, 24 Jul 2017 16:07:20 -0400
From:   Dennis Zhou <dennisz@...com>
To:     Tejun Heo <tj@...nel.org>
CC:     Christoph Lameter <cl@...ux.com>, <kernel-team@...com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        Dennis Zhou <dennisszhou@...il.com>
Subject: Re: [PATCH 07/10] percpu: fix misnomer in schunk/dchunk variable
 names

Hi Tejun,

On Mon, Jul 17, 2017 at 03:10:09PM -0400, Tejun Heo wrote:

> >  	/*
> > +	 * Initialize first chunk.
> > +	 * pcpu_first_chunk will always manage the dynamic region of the
> > +	 * first chunk.  The static region is dropped as those addresses
> 
> Would "not covered by any chunk" be clearer than "dropped"?

I've updated the comments in the new revision. This is explained in the
function comment now.

Thanks,
Dennis