linux-kernel - Re: [PATCH v7 06/16] lockdep: Detect and handle hist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170725084521.hazqpckbpg4rrucf@hirez.programming.kicks-ass.net>
Date:   Tue, 25 Jul 2017 10:45:21 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Byungchul Park <byungchul.park@....com>
Cc:     Byungchul Park <max.byungchul.park@...il.com>,
        Ingo Molnar <mingo@...nel.org>, tglx@...utronix.de,
        Michel Lespinasse <walken@...gle.com>, boqun.feng@...il.com,
        kirill@...temov.name,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-mm@...ck.org, akpm@...ux-foundation.org, willy@...radead.org,
        npiggin@...il.com, kernel-team@....com
Subject: Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring
 buffer overwrite

On Tue, Jul 25, 2017 at 03:29:45PM +0900, Byungchul Park wrote:

> _No_, as I already said.
> 
> > (/me copy paste from older email)
> > 
> > That gives:
> > 
> >         xhist[ 0] = A1
> >         xhist[ 1] = B1
> >         ...
> >         xhist[63] = B63
> > 
> > then we wrap and have:
> > 
> >         xhist[0] = B64
> > 
> > then we rewind to 1 and invalidate to arrive at:
> 
> We invalidate xhist[_0_], as I already said.
> 
> >         xhist[ 0] = B64
> >         xhist[ 1] = NULL   <-- idx
> >         xhist[ 2] = B2
> >         ...
> >         xhist[63] = B63
> > 
> > 
> > Then we do D and get
> > 
> >         xhist[ 0] = B64
> >         xhist[ 1] = D   <-- idx
> >         xhist[ 2] = B2
> >         ...
> >         xhist[63] = B63
> 
> We should get
> 
>          xhist[ 0] = NULL
>          xhist[ 1] = D   <-- idx
>          xhist[ 2] = B2
>          ...
>          xhist[63] = B63
> 
> By the way, did not you get my reply? I did exactly same answer.
> Perhaps You have not received or read my replies.
> 
> > And now there is nothing that will invalidate B*, after all, the
> > gen_id's are all after C's stamp, and the same_context_xhlock() test
> > will also pass because they're all from IRQ context (albeit not the
> > same, but it cannot tell).
> 
> It will stop at xhist[0] because it has been invalidated.
> 
> > Does this explain? Or am I still missing something?
> 
> Could you read the following reply? Not enough?
> 
> https://lkml.org/lkml/2017/7/13/214
> 
> I am sorry if my english makes you hard to understand. But I already
> answered all you asked.

Ah, I think I see. It works because you commit backwards and terminate
on the invalidate.

Yes I had seen your emails, but the penny hadn't dropped, the light bulb
didn't switch on, etc.. sometimes I'm a little dense and need a little
more help.

Thanks, I'll go look at your latest posting now.