linux-kernel - Re: [PATCH v2] mm: Drop useless local parameters of __register_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d18o7uie.fsf@concordia.ellerman.id.au>
Date:   Tue, 25 Jul 2017 19:09:29 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Dou Liyang <douly.fnst@...fujitsu.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org
Cc:     Dou Liyang <douly.fnst@...fujitsu.com>,
        David Rientjes <rientjes@...gle.com>,
        Michal Hocko <mhocko@...nel.org>,
        isimatu.yasuaki@...fujitsu.com
Subject: Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node()

Dou Liyang <douly.fnst@...fujitsu.com> writes:

> ... initializes local parameters "p_node" & "parent" for
> register_node().
>
> But, register_node() does not use them.
>
> Remove the related code of "parent" node, cleanup __register_one_node()
> and register_node().
>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Michal Hocko <mhocko@...nel.org>
> Cc: isimatu.yasuaki@...fujitsu.com
> Signed-off-by: Dou Liyang <douly.fnst@...fujitsu.com>
> Acked-by: David Rientjes <rientjes@...gle.com>
> ---
> V1 --> V2:
> Rebase it on 
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
>
>  drivers/base/node.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

That appears to be the last user of parent_node().

Can we start removing it from the topology.h headers for each arch?

cheers