linux-kernel - Re: [PATCH] kselftest/timers: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170725124019.GC19732@localhost>
Date:   Tue, 25 Jul 2017 14:40:19 +0200
From:   Miroslav Lichvar <mlichvar@...hat.com>
To:     Santosh Sivaraj <santosh@...six.org>
Cc:     linux-kernel@...r.kernel.org, John Stultz <john.stultz@...aro.org>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Paul Elder <paul.elder@...t.edu>
Subject: Re: [PATCH] kselftest/timers: fix build failure

On Tue, Jul 25, 2017 at 01:20:37PM +0530, Santosh Sivaraj wrote:
> "message" parameter was not passed to ksft_exit_skip.

It looks like this was a bad merge of 76739256 and 54f57baa, which
added the new parameter to ksft_exit_skip().

> @@ -231,7 +231,7 @@ static void init_test(void)
>  
>  	if (precision > MAX_PRECISION) {
>  		printf("[SKIP]\n");
> -		ksft_exit_skip();
> +		ksft_exit_skip("[SKIP]\n");

To avoid printing "skip" multiple times, I'd suggest to change the
argument of ksft_exit_skip to NULL.

Thanks,

-- 
Miroslav Lichvar