linux-kernel - Re: [PATCH] sh: remove references to CPU_SUBTYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d272349d-8986-b3ad-7be4-4ed57cc6d200@cogentembedded.com>
Date:   Tue, 25 Jul 2017 16:03:34 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Paul Bolle <pebolle@...cali.nl>, Paul Mundt <lethal@...ux-sh.org>
Cc:     linux-sh@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764

On 07/25/2017 03:54 PM, Sergei Shtylyov wrote:

>> Since release v2.6.29 the tree has a few references to the Kconfig
>> symbol CPU_SUBTYPE_SH7764 and the Kconfig macro
>> CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was
>> never added to the tree. Perhaps no one noticed because these references
>> were never used alone. Anyhow, these references serve no purpose and
>> can be removed.
>>
>> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
>> ---
>> Untested: I don't have the hardware. Neither do I have the compiler for
>> this architecture at hand.
> [...]
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index 33e9617..44a3d7b 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -1653,7 +1653,6 @@ static int sh_eth_open(struct net_device *ndev)
>>
>>      ret = request_irq(ndev->irq, sh_eth_interrupt,
>>  #if defined(CONFIG_CPU_SUBTYPE_SH7763) || \
>> -    defined(CONFIG_CPU_SUBTYPE_SH7764) || \
>>      defined(CONFIG_CPU_SUBTYPE_SH7757)
>>                  IRQF_SHARED,
>>  #else
>
>     This code is long gone -- what tree is your patch based upon?

    Oops, didn't realize this mail was from 2013. :-)

MBR, Sergei