linux-kernel - [PATCH v2] m68k: Restore symbol versions for symbols exported from assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1500966575-4136-1-git-send-email-geert@linux-m68k.org>
Date:   Tue, 25 Jul 2017 09:09:35 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Ben Hutchings <ben@...adent.org.uk>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Andreas Schwab <schwab@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: [PATCH v2] m68k: Restore symbol versions for symbols exported from assembly

From: Ben Hutchings <ben@...adent.org.uk>

WARNING: EXPORT symbol "__divsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__umodsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__mulsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__modsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__udivsi3" [vmlinux] version generation failed, symbol will not be versioned.

Add <asm/asm-prototypes.h> so that genksyms knows the types of these
symbols and can generate CRCs for them.

Fixes: d13ffb563044 ("m68k: move exports to definitions"
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
[geert: Add warning messages, match actual prototypes]
Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
---
Based on gccint.info

Several prototypes in the kernel disagree w.r.t. signedness of the
second parameter, and use e.g.

    signed int __divsi3(signed int, unsigned int);

v2:
  - Add warning messages, match actual prototypes.
---
 arch/m68k/include/asm/asm-prototypes.h | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 arch/m68k/include/asm/asm-prototypes.h

diff --git a/arch/m68k/include/asm/asm-prototypes.h b/arch/m68k/include/asm/asm-prototypes.h
new file mode 100644
index 0000000000000000..22ccb9c975767201
--- /dev/null
+++ b/arch/m68k/include/asm/asm-prototypes.h
@@ -0,0 +1,5 @@
+extern int __divsi3(int, int);
+extern int __modsi3(int, int);
+extern int __mulsi3(int, int);
+extern unsigned int __udivsi3(unsigned int, unsigned int);
+extern unsigned int __umodsi3(unsigned int, unsigned int);
-- 
2.7.4