linux-kernel - Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7eywjzek.wl-tiwai@suse.de>
Date:   Tue, 25 Jul 2017 17:42:59 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Sebastian Reichel" <sebastian.reichel@...labora.co.uk>
Cc:     "Tony Lindgren" <tony@...mide.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Sebastian Reichel" <sre@...nel.org>,
        <alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>
Subject: Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update

On Tue, 25 Jul 2017 17:10:25 +0200,
Sebastian Reichel wrote:
> 
> From: Tony Lindgren <tony@...mide.com>
> 
> Some codecs may need to use this from loadable modules. Without
> this patch compilation for this kind of codec will fail with the
> following error:
> 
> ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko]
> undefined!
> 
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

If you do export the function, please make its comments prettier, so
that it appears in kernel documentation properly as an API function.

Also, in general, we use snd_ prefix for the exported stuff.
You'd need to rename it accordingly, too.

Last but not least, this is specific to ASoC, so use "ASoC" prefix to
the subject line.


thanks,

Takashi

> ---
>  sound/soc/soc-pcm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index dcc5ece08668..4de7d86ea6fb 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -2539,6 +2539,8 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card)
>  	mutex_unlock(&card->mutex);
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(soc_dpcm_runtime_update);
> +
>  int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute)
>  {
>  	struct snd_soc_dpcm *dpcm;
> -- 
> 2.13.2
> 
>