linux-kernel - Re: [PATCH] objtool: make orc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170725154903.22lf6srssd6n36lk@treble>
Date:   Tue, 25 Jul 2017 10:49:03 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: make orc_types.h headers match

On Tue, Jul 25, 2017 at 05:28:48PM +0200, Arnd Bergmann wrote:
> Building objtool causes a warning on the latest linux-next kernels:
> 
> warning: objtool: orc_types.h differs from kernel
> 
> From what I can tell, we have two slightly different copies of the same
> header, and we try to ensure they are the same with the warning.

Oops!

> This picks the copy from the x86 headers (without the __packed
> annotation), by roll of dice.

You lost ;-)  It should be __packed.

BTW this will also be fixed when the ORC unwinder gets merged, which
will presumably be soon.

> Fixes: 39358a033b2e ("objtool, x86: Add facility for asm code to provide unwind hints")

^^^ This is the one that introduced the bug.

-- 
Josh