linux-kernel - Re: [PATCH v2] thunderbolt: Do not enumerate more ports from DROM than the controller has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1500998733.3327.2@smtp.gmail.com>
Date:   Tue, 25 Jul 2017 18:05:33 +0200
From:   Christian Kellner <ckellner@...hat.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        Lukas Wunner <lukas@...ner.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] thunderbolt: Do not enumerate more ports from DROM
 than the controller has

Hi everyone,

> +	/*
> +	 * Some DROMs list more ports than the controller actually has
> +	 * so we skip those but allow the parser to continue.
> +	 */
> +	if (header->index > sw->config.max_port_number) {
> +		dev_info_once(&sw->dev, "ignoring unnecessary extra entries in 
> DROM\n");
> +		return 0;
> +	}
> +
>  	port = &sw->ports[header->index];
>  	port->disabled = header->port_disabled;
>  	if (port->disabled)

Fixes the bug, everything works as expected (tested on boot,
plugging in, key based authorization), so:

Tested-by: Christian Kellner <ckellner@...hat.com>