linux-kernel - Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2537138.AhdhMFtmoG@aspire.rjw.lan>
Date:   Tue, 25 Jul 2017 18:10:57 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend()

On Tuesday, July 25, 2017 01:00:12 PM Mika Westerberg wrote:
> On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > 
> > On one of my test machines nhi_mailbox_cmd() called from icm_suspend()
> > times out and returnes an error which then is propagated to the
> > caller and causes the entire system suspend to be aborted which isn't
> > very useful.
> > 
> > Instead of aborting system suspend, print the error into the log
> > and continue.
> 
> I agree, it should not prevent suspend but I wonder why it fails in the
> first place? Can you check what is the return value?

As per the above, the error is a timeout, ie. -ETIMEDOUT.