linux-kernel - Re: [PATCH wq/for-4.13-fixes] workqueue: implicit ordered attribute should be overridable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170725172940.GF3216015@devbig577.frc2.facebook.com>
Date:   Tue, 25 Jul 2017 13:29:40 -0400
From:   Tejun Heo <tj@...nel.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Alexei Potashnik <alexei@...estorage.com>,
        kernel test robot <xiaolong.ye@...el.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>, lkp@...org,
        kernel-team@...com
Subject: Re: [PATCH wq/for-4.13-fixes] workqueue: implicit ordered attribute
 should be overridable

On Sun, Jul 23, 2017 at 08:36:15AM -0400, Tejun Heo wrote:
> 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be
> ordered") automatically enabled ordered attribute for unbound
> workqueues w/ max_active == 1.  Because ordered workqueues reject
> max_active and some attribute changes, this implicit ordered mode
> broke cases where the user creates an unbound workqueue w/ max_active
> == 1 and later explicitly changes the related attributes.
> 
> This patch distinguishes explicit and implicit ordered setting and
> overrides from attribute changes if implict.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Fixes: 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")

Applied to wq/for-4.13-fixes.

Thanks.

-- 
tejun