linux-kernel - Re: [PATCH] drm/hisilicon: fix build error without fbdev emulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2BqLJUCXKuv0sPAaqOAn1F8Mv1_N9cOku6UfCNWQD=FQ@mail.gmail.com>
Date:   Tue, 25 Jul 2017 20:04:27 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Arnd Bergmann <arnd@...db.de>,
        Xinliang Liu <z.liuxinliang@...ilicon.com>,
        Rongrong Zou <zourongrong@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Chen Feng <puck.chen@...ilicon.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Jyri Sarha <jsarha@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Thierry Reding <treding@...dia.com>,
        Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: [PATCH] drm/hisilicon: fix build error without fbdev emulation

On Tue, Jul 25, 2017 at 5:53 PM, Daniel Vetter <daniel@...ll.ch> wrote:
> On Tue, Jul 25, 2017 at 05:33:25PM +0200, Arnd Bergmann wrote:

>>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
>> index 1178341c3858..d48102d1a7a4 100644
>> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
>> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
>> @@ -121,6 +121,7 @@ static int kirin_drm_kms_init(struct drm_device *dev)
>>       /* init kms poll for handling hpd */
>>       drm_kms_helper_poll_init(dev);
>>
>> +#ifdef CONFIG_DRM_FBDEV_EMULATION
>>       priv->fbdev = drm_fbdev_cma_init(dev, 32,
>>                                        dev->mode_config.num_connector);
>>       if (IS_ERR(priv->fbdev)) {
>> @@ -128,11 +129,13 @@ static int kirin_drm_kms_init(struct drm_device *dev)
>>               ret = PTR_ERR(priv->fbdev);
>>               goto err_cleanup_poll;
>>       }
>> -
>> +#endif
>
> Could we instead stop compling out priv->fbdev? There's nothing
> driver-specific here, so teh #ifdef are kinda annoying ...

Yes, I guess that would be better, I just didn't want to do too much
of a rework. If we remove the #ifdef here, we should replace all
instances in that driver.

I'll send a patch to do that and let you pick which one you apply.

> And saving that one pointer in a really huge structure is somewhat silly.

It looks like it's the only member in that structure, but that doesn't
make a big difference either, since there is only one instance in
the system.

>> +#ifdef CONFIG_DRM_FBDEV_EMULATION
>>  err_cleanup_poll:
>>       drm_kms_helper_poll_fini(dev);
>
> poll helpers aren't fbdev specific. Why do we need this? Is this just to
> shut up gcc?

Yes, gcc warns about the unused label here otherwise.

         Arnd