linux-kernel - [RFC] hwmon: (ibmpowernv) Add support for reset-history sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1501048538-23160-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
Date:   Wed, 26 Jul 2017 11:25:38 +0530
From:   Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
To:     clg@...d.org, linux@...ck-us.net
Cc:     jdelvare@...e.com, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, linux-hwmon@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        ego@...ux.vnet.ibm.com, svaidy@...ux.vnet.ibm.com,
        stewart@...ux.vnet.ibm.com,
        Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
Subject: [RFC] hwmon: (ibmpowernv) Add support for reset-history sensors

In P9, OCC allows for clearing the sensor min-max history. This patch
exports attribute to reset history when set will clear the history of
all the sensors owned by CSM and belonging to the chip.

Signed-off-by: Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
---
This patch is on top of this patchset:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1453891.html

This patch creates a non-standard attribute called as reset_historyX
which clears the lowest and highest of all the sensors like power,
temperature, voltage belonging to the chip.

 drivers/hwmon/ibmpowernv.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
index 5ccdd0b..611e472 100644
--- a/drivers/hwmon/ibmpowernv.c
+++ b/drivers/hwmon/ibmpowernv.c
@@ -51,6 +51,7 @@ enum sensors {
 	POWER_SUPPLY,
 	POWER_INPUT,
 	CURRENT,
+	RESET_HISTORY,
 	MAX_SENSOR_TYPE,
 };
 
@@ -78,6 +79,7 @@ enum sensors {
 	{ "in"    },
 	{ "power" },
 	{ "curr"  },
+	{ "reset_history" },
 };
 
 struct sensor_data {
@@ -126,6 +128,25 @@ static ssize_t show_label(struct device *dev, struct device_attribute *devattr,
 	return sprintf(buf, "%s\n", sdata->label);
 }
 
+static ssize_t store_reset_history(struct device *dev,
+				   struct device_attribute *devattr,
+				   const char *buf, size_t count)
+{
+	struct sensor_data *sdata = container_of(devattr, struct sensor_data,
+						 dev_attr);
+	int rc;
+	int reset;
+
+	rc = kstrtoint(buf, 0, &reset);
+	if (rc)
+		return rc;
+
+	if (reset == 1)
+		rc = opal_sensor_groups_clear_history(sdata->id);
+
+	return rc ? rc : count;
+}
+
 static int __init get_logical_cpu(int hwcpu)
 {
 	int cpu;
@@ -458,6 +479,16 @@ static int create_device_attrs(struct platform_device *pdev)
 
 		create_hwmon_attr(&sdata[count], attr_name, show_sensor);
 
+		if (type == RESET_HISTORY) {
+			snprintf(sdata[count].name, MAX_ATTR_LEN, "%s%d",
+				 sensor_groups[type].name,
+				 sdata[count].hwmon_index);
+
+			sdata[count].dev_attr.attr.mode = 0220;
+			sdata[count].dev_attr.store = store_reset_history;
+			sdata[count].dev_attr.show = NULL;
+		}
+
 		pgroups[type]->attrs[sensor_groups[type].attr_count++] =
 				&sdata[count++].dev_attr.attr;
 
-- 
1.8.3.1