linux-kernel - Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d59b609-aeec-9177-8849-da1fbd386191@arm.com>
Date:   Wed, 26 Jul 2017 09:04:23 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

On 26/07/17 05:03, Masahiro Yamada wrote:
> Some irqchip drivers have a Kconfig prompt.  When we run menuconfig
> or friends, those drivers are directly listed in the "Device Drivers"
> menu level.  This does not look nice.  Create a sub-system level menu.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/irqchip/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index f1fd5f44d1d4..7b66313a2952 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -1,3 +1,5 @@
> +menu "IRQ chip support"
> +
>  config IRQCHIP
>  	def_bool y
>  	depends on OF_IRQ
> @@ -306,3 +308,5 @@ config QCOM_IRQ_COMBINER
>  	help
>  	  Say yes here to add support for the IRQ combiner devices embedded
>  	  in Qualcomm Technologies chips.
> +
> +endmenu
> 

I'm very reluctant to introduce this. IMHO, interrupt controllers are
way too low level a thing to let them be selected by the user. They
really should be selected by the platform that needs them

Do you have any example in mind where having a user-selectable interrupt
controller actually makes sense on its own?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...