lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Jul 2017 15:50:03 +0300 From: "Michael S. Tsirkin" <mst@...hat.com> To: Jason Wang <jasowang@...hat.com> Cc: Andrew Jones <drjones@...hat.com>, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, Sebastian Andrzej Siewior <bigeasy@...utronix.de> Subject: Re: [PATCH] virtio-net: fix module unloading On Wed, Jul 26, 2017 at 11:52:07AM +0800, Jason Wang wrote: > > > On 2017年07月24日 21:38, Andrew Jones wrote: > > Unregister the driver before removing multi-instance hotplug > > callbacks. This order avoids the warning issued from > > __cpuhp_remove_state_cpuslocked when the number of remaining > > instances isn't yet zero. > > > > Fixes: 8017c279196a ("net/virtio-net: Convert to hotplug state machine") > > Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > > Signed-off-by: Andrew Jones <drjones@...hat.com> > > --- > > drivers/net/virtio_net.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 99a26a9efec1..f41ab0ea942a 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -2743,9 +2743,9 @@ module_init(virtio_net_driver_init); > > static __exit void virtio_net_driver_exit(void) > > { > > + unregister_virtio_driver(&virtio_net_driver); > > cpuhp_remove_multi_state(CPUHP_VIRT_NET_DEAD); > > cpuhp_remove_multi_state(virtionet_online); > > - unregister_virtio_driver(&virtio_net_driver); > > } > > module_exit(virtio_net_driver_exit); > > Acked-by: Jason Wang <jasowang@...hat.com> Thanks for the review! I merged it before the tag and don't want to rebase. Sorry about that. -- MST
Powered by blists - more mailing lists