linux-kernel - Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1707261620430.2186@nanos>
Date:   Wed, 26 Jul 2017 16:24:25 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Marc Zyngier <marc.zyngier@....com>
cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Jason Cooper <jason@...edaemon.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

On Wed, 26 Jul 2017, Marc Zyngier wrote:
> On 26/07/17 14:14, Masahiro Yamada wrote:
> > The irqchip maintainers applied drivers
> > with user-configurable Kconfig entries.
> 
> They are *not* user-selectable, since there is *NO* menu entry. *You*
> are making them user-selectable, and I'm objecting to that.

Masahiro is right. They are user selectable.

Enable CONFIG_SOC_IMX51 and you'll get a prompt for

       TS-4800 IRQ controller

in the middle of the 'Device Drivers' menu. Same for the other options,
which have prompts. The irqchip Kconfig is included from drivers/Kconfig so
there is menu context, just not a proper one.

I agree that this is crap and these prompts should be removed and the irq
thingy selected by the stuff which needs it.

Thanks,

	tglx