linux-kernel - Re: [PATCH] drm: adding SDI to drm_connector_enum_list

Open Source and information security mailing list archives

Message-ID: <20170726143811.jmytjvdr7xkl5lyx@phenom.ffwll.local>
Date:   Wed, 26 Jul 2017 16:38:12 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Saurabh Sengar <saurabh.singh@...inx.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        airlied@...ux.ie, saurabhs@...inx.com, dineshk@...inx.com
Subject: Re: [PATCH] drm: adding SDI to drm_connector_enum_list

On Wed, Jul 26, 2017 at 10:22:49AM +0530, Saurabh Sengar wrote:
> adding SDI to drm connector list
> 
> Signed-off-by: Saurabh Sengar <saurabhs@...inx.com>

This is an uapi change, i.e. userspace needs to be updated. Do you
_really_ need this? I'd recommend to just use something existing (go with
VIRTUAL maybe, not sure).

Either way, needs to come together with the actual users and userspace
side patches. If you really want this.
-Daniel
> ---
>  drivers/gpu/drm/drm_connector.c | 1 +
>  include/uapi/drm/drm_mode.h     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 2db7fb5..ea48ddb 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -86,6 +86,7 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = {
>  	{ DRM_MODE_CONNECTOR_VIRTUAL, "Virtual" },
>  	{ DRM_MODE_CONNECTOR_DSI, "DSI" },
>  	{ DRM_MODE_CONNECTOR_DPI, "DPI" },
> +	{ DRM_MODE_CONNECTOR_SDI, "SDI" },
>  };
>  
>  void drm_connector_ida_init(void)
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index df0e350..9b8d204 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -247,6 +247,7 @@ struct drm_mode_get_encoder {
>  #define DRM_MODE_CONNECTOR_VIRTUAL      15
>  #define DRM_MODE_CONNECTOR_DSI		16
>  #define DRM_MODE_CONNECTOR_DPI		17
> +#define DRM_MODE_CONNECTOR_SDI		18
>  
>  struct drm_mode_get_connector {
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives