linux-kernel - Re: [RFC/RFT PATCH] KVM: nVMX: fixes to nested virt interrupt injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c57ea9ad-f0bd-0184-fa81-0bc3c2c08f0a@redhat.com>
Date:   Wed, 26 Jul 2017 17:23:38 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Jim Mattson <jmattson@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kvm list <kvm@...r.kernel.org>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [RFC/RFT PATCH] KVM: nVMX: fixes to nested virt interrupt
 injection

On 26/07/2017 16:55, Jim Mattson wrote:
> Hmmm.  That field isn't writable on all microarchitectures.

You're right... I'll see if there's a simple workaround, or it requires
to rework reflection of EXCEPTION_NMI vmexits.  The latter would fix
PFEC_MASK/MATCH, too...

Paolo

> On Wed, Jul 26, 2017 at 7:48 AM, Paolo Bonzini <pbonzini@...hat.com
> <mailto:pbonzini@...hat.com>> wrote:
> 
>     On 25/07/2017 23:08, Jim Mattson wrote:
>     >
>     >     +
>     >     +       if (vcpu->arch.exception.has_error_code) {
>     >     +               vmcs_write32(VM_EXIT_INTR_ERROR_CODE,
>     >     vcpu->arch.exception.error_code);
>     >
>     >
>     > Should this be vmcs12->vm_exit_intr_error_code
>     > = vcpu->arch.exception.error_code?
> 
>     No, this writes to the vmcs02 and prepare_vmcs12 copies it to the
>     vmcs12.
> 
>     Paolo
> 
>