linux-kernel - [tip:perf/core] perf annotate stdio: Fix --show-total-period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-lh2nh89rtqn5x5vbfthw6qml@git.kernel.org>
Date:   Wed, 26 Jul 2017 10:21:11 -0700
From:   tip-bot for Taeung Song <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, acme@...hat.com, mliska@...e.cz, jolsa@...hat.com,
        tglx@...utronix.de, linux-kernel@...r.kernel.org, mingo@...nel.org,
        milian.wolff@...b.com, treeze.taeung@...il.com, namhyung@...nel.org
Subject: [tip:perf/core] perf annotate stdio: Fix --show-total-period

Commit-ID:  585d93c5ffccced26689e34095c0d74ef20a07d6
Gitweb:     http://git.kernel.org/tip/585d93c5ffccced26689e34095c0d74ef20a07d6
Author:     Taeung Song <treeze.taeung@...il.com>
AuthorDate: Fri, 21 Jul 2017 11:58:20 -0300
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Tue, 25 Jul 2017 11:23:36 -0300

perf annotate stdio: Fix --show-total-period

We were showing the total number of samples, not the total period as
asked by the user, fix it.

Reported-by: Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <jolsa@...hat.com>
Cc: Martin Liška <mliska@...e.cz>
Cc: Milian Wolff <milian.wolff@...b.com>
Link: http://lkml.kernel.org/n/tip-lh2nh89rtqn5x5vbfthw6qml@git.kernel.org
Fixes: 0c4a5bcea460 ("perf annotate: Display total number of samples with --show-total-period")
[ split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/annotate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 00e085f..004072f 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1143,7 +1143,7 @@ static int disasm_line__print(struct disasm_line *dl, struct symbol *sym, u64 st
 
 			if (symbol_conf.show_total_period)
 				color_fprintf(stdout, color, " %7" PRIu64,
-					      sample.nr_samples);
+					      sample.period);
 			else
 				color_fprintf(stdout, color, " %7.2f", percent);
 		}