linux-kernel - Re: [PATCH 2/2] drm/msm: gpu: don't abuse dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0hQaWmNmRZv4fFH-dq7FxHDBh7dshzDEVKZU6vNhq69g@mail.gmail.com>
Date:   Wed, 26 Jul 2017 22:01:10 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     linux-arm-msm@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        freedreno@...ts.freedesktop.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Clark <robdclark@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Sushmita Susheelendra <ssusheel@...eaurora.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/msm: gpu: don't abuse dma_alloc for non-DMA allocations

 On Jul 26, 2017 6:35 PM, "Jordan Crouse" <jcrouse@...eaurora.org> wrote:

> >       if (!IS_ENABLED(CONFIG_ARCH_QCOM))
> >               return -EINVAL;
> >
> > +     np = of_get_child_by_name(dev->of_node, "zap-shader");
> > +     if (!np)
> > +             return -ENODEV;
> > +
> > +     np = of_parse_phandle(dev->of_node, "memory-region", 0);
>
> I think this should be np = of_parse_phandle(np, "memory-region", 0);
>

Ok, fixed.

> > @@ -373,44 +393,6 @@ static int a5xx_zap_shader_resume(struct msm_gpu *gpu)
> >  }
> >
> >  /* Set up a child device to "own" the zap shader */
>
> This now incorrect comment can be zapped (pun intended).

Done.

> > -static int a5xx_zap_shader_dev_init(struct device *parent, struct device *dev)
> > -{
> > -     struct device_node *node;
> > -     int ret;
> > -
> > -     if (dev->parent)
> > -             return 0;
> > -
>
> With above changes,
> Acked-and-Tested-By: Jordan Crouse <jcrouse@...eaurora.org>

Thanks for testing!

I've re-sent this patch as v3 now (this one was actually v2, depending on
how you count). I decided not to resend patch 1/2 of the series. We still
need that too, but they are independent. Hope that's ok.