linux-kernel - RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD00436A7@AcuExch.aculab.com>
Date:   Thu, 27 Jul 2017 07:45:25 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Brijesh Singh' <brijesh.singh@....com>,
        "H. Peter Anvin" <hpa@...or.com>, Arnd Bergmann <arnd@...db.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        David Howells <dhowells@...hat.com>,
        Paul Mackerras <paulus@...ba.org>,
        Christoph Lameter <cl@...ux.com>,
        Jonathan Corbet <corbet@....net>,
        Radim Krcmár <rkrcmar@...hat.com>,
        Piotr Luc <piotr.luc@...el.com>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Airlie <airlied@...hat.com>, Borislav Petkov <bp@...e.de>,
        Tom Lendacky <thomas.lendacky@....com>,
        Kees Cook <keescook@...omium.org>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>,
        Reza Arbab <arbab@...ux.vnet.ibm.com>,
        Andy Lutomirski <luto@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Laura Abbott <labbott@...hat.com>,
        Tony Luck <tony.luck@...el.com>,
        "Ard.Biesheuvel@...or.com" <Ard.Biesheuvel@...or.com>
Subject: RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV
 is active

From: Brijesh Singh
> Sent: 26 July 2017 21:07
...
> I am not sure if I understand your concern.
> 
> Are you commenting on amount of code duplication ? If so, I can certainly improve
> and use the similar macro used into header file to generate the functions body.

If you are careful the real functions could expand the inline functions
that get used when SEV is compiled out.

Oh, if you are looking at this, can you fix memcpy_to_io()
so that it is never 'rep movsb'?

	David