linux-kernel - Re: [PATCH v5 03/14] spi: qup: Add completion timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2017 16:30:07 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Varadarajan Narayanan <varada@...eaurora.org>
Cc:     kbuild-all@...org, broonie@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, andy.gross@...aro.org,
        david.brown@...aro.org, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        Varadarajan Narayanan <varada@...eaurora.org>
Subject: Re: [PATCH v5 03/14] spi: qup: Add completion timeout

Hi Varadarajan,

[auto build test ERROR on spi/for-next]
[also build test ERROR on v4.13-rc2 next-20170726]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Varadarajan-Narayanan/spi-qup-Fixes-and-add-support-for-64k-transfers/20170725-033101
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

Note: the linux-review/Varadarajan-Narayanan/spi-qup-Fixes-and-add-support-for-64k-transfers/20170725-033101 HEAD 88e143f949247832b744d84f5163033eaba09abc builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers//spi/spi-qup.c: In function 'spi_qup_do_dma':
>> drivers//spi/spi-qup.c:361:47: error: 'qup' undeclared (first use in this function)
     if (rx_done && !wait_for_completion_timeout(&qup->done, timeout))
                                                  ^~~
   drivers//spi/spi-qup.c:361:47: note: each undeclared identifier is reported only once for each function it appears in

vim +/qup +361 drivers//spi/spi-qup.c

   333	
   334	static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer,
   335				  unsigned long timeout)
   336	{
   337		dma_async_tx_callback rx_done = NULL, tx_done = NULL;
   338		int ret;
   339	
   340		if (xfer->rx_buf)
   341			rx_done = spi_qup_dma_done;
   342		else if (xfer->tx_buf)
   343			tx_done = spi_qup_dma_done;
   344	
   345		if (xfer->rx_buf) {
   346			ret = spi_qup_prep_sg(master, xfer, DMA_DEV_TO_MEM, rx_done);
   347			if (ret)
   348				return ret;
   349	
   350			dma_async_issue_pending(master->dma_rx);
   351		}
   352	
   353		if (xfer->tx_buf) {
   354			ret = spi_qup_prep_sg(master, xfer, DMA_MEM_TO_DEV, tx_done);
   355			if (ret)
   356				return ret;
   357	
   358			dma_async_issue_pending(master->dma_tx);
   359		}
   360	
 > 361		if (rx_done && !wait_for_completion_timeout(&qup->done, timeout))
   362			return -ETIMEDOUT;
   363	
   364		if (tx_done && !wait_for_completion_timeout(&qup->done, timeout))
   365			return -ETIMEDOUT;
   366	
   367		return 0;
   368	}
   369	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (36296 bytes)