linux-kernel - Re: [PATCH 1/2] ASoC: hdmi-codec: Allow drivers to restrict sample sizes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4452e1f-d5d6-4940-c7b4-9a78b92fe641@linaro.org>
Date:   Thu, 27 Jul 2017 13:04:16 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Jyri Sarha <jsarha@...com>, Mark Brown <broonie@...nel.org>,
        alsa-devel@...a-project.org
Cc:     Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: hdmi-codec: Allow drivers to restrict sample
 sizes.



On 27/07/17 11:34, Jyri Sarha wrote:
> On 07/17/17 17:02, srinivas.kandagatla@...aro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>
>> Currently hdmi client drivers does have means to limit the
>> sample sizes that it can only support. Having formats parameter
>> option would solve this.
>>
>> This issue was noticed on DB410c board when adv7511 hdmi codec driver
>> failed to play a 32 bits audio samples, as it does not support them.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> I left this feature out because I did not need it. All the HDMI encoders
> I have used are able to take all the i2s formats I am able to send.
> 
> You should probably also update the comment above I2S_FORMATS
> definition. Othewise:
Make sense, I will update it and send a v2 patch.


> 
> Reviewed-by: Jyri Sarha <jsarha@...com>

thanks
--srini
> 
> 
>> ---
>>   include/sound/hdmi-codec.h    | 1 +
>>   sound/soc/codecs/hdmi-codec.c | 3 +++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h
>> index 9483c55f871b..89fc4cce5785 100644
>> --- a/include/sound/hdmi-codec.h
>> +++ b/include/sound/hdmi-codec.h
>> @@ -104,6 +104,7 @@ struct hdmi_codec_pdata {
>>   	uint i2s:1;
>>   	uint spdif:1;
>>   	int max_i2s_channels;
>> +	u64 formats;
>>   	void *data;
>>   };
>>   
>> diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
>> index 22ed0dc88f0a..1ece73f4be92 100644
>> --- a/sound/soc/codecs/hdmi-codec.c
>> +++ b/sound/soc/codecs/hdmi-codec.c
>> @@ -780,6 +780,9 @@ static int hdmi_codec_probe(struct platform_device *pdev)
>>   		hcp->daidrv[i] = hdmi_i2s_dai;
>>   		hcp->daidrv[i].playback.channels_max =
>>   			hcd->max_i2s_channels;
>> +
>> +		if (hcd->formats)
>> +			hcp->daidrv[i].playback.formats = hcd->formats;
>>   		i++;
>>   	}
>>   
>>
>