linux-kernel - [mmots] build error: mm: prevent racy access to tlb_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170727123228.GA573@tigerII.localdomain>
Date:   Thu, 27 Jul 2017 21:32:28 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Nadav Amit <namit@...are.com>
Cc:     Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...nel.org>, linux-kernel@...r.kernel.org
Subject: [mmots] build error: mm: prevent racy access to tlb_flush_pending

Hello,

8c636138f497b36ae95f ("mm: prevent racy access to tlb_flush_pending") kills
the build

kernel/fork.c: In function ‘mm_init’:
kernel/fork.c:810:18: error: ‘struct mm_struct’ has no member named ‘tlb_flush_pending’; did you mean ‘tlb_flush_batched’?
  atomic_set(&mm->tlb_flush_pending, 0);
                  ^~~~~~~~~~~~~~~~~
                  tlb_flush_batched



replacing clear_tlb_flush_pending() with a direct ->tlb_flush_pending
access

@@ -807,7 +807,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
        mm_init_aio(mm);
        mm_init_owner(mm, p);
        mmu_notifier_mm_init(mm);
-       clear_tlb_flush_pending(mm);
+       atomic_set(&mm->tlb_flush_pending, 0);


doesn't work on on !CONFIG_NUMA_BALANCING && !CONFIG_COMPACTION systems.

	-ss