linux-kernel - Re: [PATCH] PM / runtime: Document new pm_runtime_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2017 15:20:16 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] PM / runtime: Document new pm_runtime_set_suspended constraint

On 24 July 2017 at 11:53, Johan Hovold <johan@...nel.org> wrote:
> Since commit a8636c89648a ("PM / Runtime: Don't allow to suspend a
> device with an active child") it is no longer permitted to set
> RPM_SUSPENDED state for a device with active children unless
> power.ignore_children is set.
>
> Update the documentation to reflect this.
>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  Documentation/power/runtime_pm.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/power/runtime_pm.txt b/Documentation/power/runtime_pm.txt
> index 0fde3dcf077a..625549d4c74a 100644
> --- a/Documentation/power/runtime_pm.txt
> +++ b/Documentation/power/runtime_pm.txt
> @@ -435,7 +435,8 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h:
>        PM status to 'suspended' and update its parent's counter of 'active'
>        children as appropriate (it is only valid to use this function if
>        'power.runtime_error' is set or 'power.disable_depth' is greater than
> -      zero)
> +      zero); it will fail and return an error code if the device has a child
> +      which is active and the 'power.ignore_children' flag is unset
>
>    bool pm_runtime_active(struct device *dev);
>      - return true if the device's runtime PM status is 'active' or its
> --
> 2.13.3
>