linux-kernel - Re: [PATCH v2 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1a83qvwmv.fsf@oracle.com>
Date:   Thu, 27 Jul 2017 09:26:32 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Suganath Prabu S <suganath-prabu.subramani@...adcom.com>
Cc:     jejb@...nel.org, hch@...radead.org, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, Sathya.Prakash@...adcom.com,
        kashyap.desai@...adcom.com, linux-kernel@...r.kernel.org,
        chaitra.basappa@...adcom.com, sreekanth.reddy@...adcom.com,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v2 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe  devices


Suganath,

> * Added support for translating the SGLs associated with incoming
> commands either to IEE SGL or NVMe PRPs for NVMe devices.

This all seems very convoluted. You should rely on the block layer
infrastructure instead of doing all this slicing and dicing by hand.

If the attached device is an NVMe drive, call blk_queue_virt_boundary()
and you will only receive requests that are suitable for a device with
PRP-style scatterlist constraints.

-- 
Martin K. Petersen	Oracle Linux Engineering