linux-kernel - Re: [PATCH v2] KVM: x86: Avoid guest page table walk when gpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86b4e9e3-b594-4470-375e-10a2a3e6a4ea@redhat.com>
Date:   Thu, 27 Jul 2017 15:49:14 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Brijesh Singh <brijesh.singh@....com>, rkrcmar@...hat.com,
        joro@...tes.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, Thomas.Lendacky@....com
Subject: Re: [PATCH v2] KVM: x86: Avoid guest page table walk when
 gpa_available is set

On 19/05/2017 17:12, Brijesh Singh wrote:
> -	    vcpu_is_mmio_gpa(vcpu, addr, exception->address, write) &&
>  	    (addr & ~PAGE_MASK) == (exception->address & ~PAGE_MASK)) {
                                    ^^^^^^^^^^^^^^^^^^

I think this should be vcpu->arch.gpa_val.

Paolo

> -		gpa = exception->address;
> -		goto mmio;
> -	}
> +		gpa = vcpu->arch.gpa_val;
> +		ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write);
> +	} else {
>