linux-kernel - Re: [PATCH 041/102] mmc: tegra: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2017 16:49:05 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 041/102] mmc: tegra: explicitly request exclusive reset control

On 19 July 2017 at 17:25, Philipp Zabel <p.zabel@...gutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Jonathan Hunter <jonathanh@...dia.com>
> Cc: linux-mmc@...r.kernel.org
> Cc: linux-tegra@...r.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>


Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-tegra.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7f93079c7a3ad..f668a6fa17654 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -508,7 +508,8 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
>         clk_prepare_enable(clk);
>         pltfm_host->clk = clk;
>
> -       tegra_host->rst = devm_reset_control_get(&pdev->dev, "sdhci");
> +       tegra_host->rst = devm_reset_control_get_exclusive(&pdev->dev,
> +                                                          "sdhci");
>         if (IS_ERR(tegra_host->rst)) {
>                 rc = PTR_ERR(tegra_host->rst);
>                 dev_err(&pdev->dev, "failed to get reset control: %d\n", rc);
> --
> 2.11.0
>